hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-3505: Making the log4j threshold overrideable
Date Mon, 24 Sep 2012 22:23:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7238/#review11863
-----------------------------------------------------------


Looks good overall. Please fix the 'log4j.threshold' spelling error and see if this changes
the behavior. Thanks.


trunk/common/src/java/conf/hive-log4j.properties
<https://reviews.apache.org/r/7238/#comment25400>

    "threshhold" should be "threshold". I'm wondering if this spelling error is one of the
reasons this hasn't been working?


- Carl Steinbach


On Sept. 24, 2012, 10:17 p.m., Sean Mackrory wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7238/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2012, 10:17 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Description
> -------
> 
> I describe the motivation for this change in the bug.
> 
> 
> This addresses bug HIVE-3505.
>     https://issues.apache.org/jira/browse/HIVE-3505
> 
> 
> Diffs
> -----
> 
>   trunk/common/src/java/conf/hive-log4j.properties 1389562 
> 
> Diff: https://reviews.apache.org/r/7238/diff/
> 
> 
> Testing
> -------
> 
> Used Hive on a pseudo-distributed Hadoop installation. Was able to override the log4j
threshold and enable audit-logging when starting a service by invoking with -Dhive.log.threshold=INFO.
> 
> 
> Thanks,
> 
> Sean Mackrory
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message