hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "namit jain" <nj...@fb.com>
Subject Re: Review Request: HIVE-3392 - Review request
Date Wed, 12 Sep 2012 05:04:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7004/#review11384
-----------------------------------------------------------


Please add a new testcase - 
There is no easy way to add a .q file with the semantics you want.
Can you try the following - I am not sure it will work

add jar foo.jar

create table T using foo.jar;
!mv bar.jar foo.jar
add jar foo.jar again

drop table T

Can you think of a way to add a testcase for this, if the above does not work ?
There is 'reset' command - I am not sure if it removes the jars also.
Can you confirm ?



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/7004/#comment24425>

    space after if 


- namit jain


On Sept. 12, 2012, 3:20 a.m., Ajesh kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7004/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2012, 3:20 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Description
> -------
> 
> Added logic to skip the table schema validation if the command is a drop command.
> 
> 
> This addresses bug HIVE-3392.
>     https://issues.apache.org/jira/browse/HIVE-3392
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 271554c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b4ee673 
> 
> Diff: https://reviews.apache.org/r/7004/diff/
> 
> 
> Testing
> -------
> 
> Able to drop table even if the user defined SerDe jar is not added to classpath.
> 
> 
> Thanks,
> 
> Ajesh kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message