hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "namit jain" <nj...@fb.com>
Subject Re: Review Request: HIVE-3392 - Review request
Date Tue, 11 Sep 2012 05:56:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7004/#review11316
-----------------------------------------------------------


Can you add a test ?


ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/7004/#comment24332>

    formatting: can you add 2 spaces 



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/7004/#comment24333>

    nit: space at the end



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/7004/#comment24334>

    if (
    
    space after if
    
    if (...) {
      action
    }
    
    
    instead of 
    
    if (..) 
    action



ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/7004/#comment24335>

    no tabs


- namit jain


On Sept. 11, 2012, 5:10 a.m., Ajesh kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7004/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 5:10 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Description
> -------
> 
> Added logic to skip the table schema validation if the command is a drop command.
> 
> 
> This addresses bug HIVE-3392.
>     https://issues.apache.org/jira/browse/HIVE-3392
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 271554c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b4ee673 
> 
> Diff: https://reviews.apache.org/r/7004/diff/
> 
> 
> Testing
> -------
> 
> Able to drop table even if the user defined SerDe jar is not added to classpath.
> 
> 
> Thanks,
> 
> Ajesh kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message