hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: Hive JDBC doesn't support TIMESTAMP column
Date Mon, 10 Sep 2012 21:32:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5504/#review11287
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
<https://reviews.apache.org/r/5504/#comment24230>

    Formatting: Missing space between "){"



http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
<https://reviews.apache.org/r/5504/#comment24231>

    According to the chart (taken from the back of the JDBC 4.0 spec) that I attached to HIVE-2957
getTimestamp() is also supposed to handle conversions from VARCHAR/STRING types to Timestamps.
It would be cool to get that fixed here. If you don't have time can you please open a followup
JIRA? Thanks.


- Carl Steinbach


On June 21, 2012, 11:09 p.m., Richard Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5504/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 11:09 p.m.)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Description
> -------
> 
> See HIVE-2957
> 
> 
> This addresses bug HIVE-2957.
>     https://issues.apache.org/jira/browse/HIVE-2957
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/data/files/datatypes.txt 1352206 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
1352206 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java
1352206 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java
1352206 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/Utils.java
1352206 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java
1352206 
> 
> Diff: https://reviews.apache.org/r/5504/diff/
> 
> 
> Testing
> -------
> 
> ant test -Dtestcase=TestJdbcDriver passed.
> 
> 
> Thanks,
> 
> Richard Ding
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message