hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajesh kumar" <ajesh...@yahoo.co.in>
Subject Review Request: HIVE-3141 - Review request
Date Wed, 05 Sep 2012 09:04:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6919/
-----------------------------------------------------------

Review request for hive and namit jain.


Description
-------

Approach: provided extra verification for the syntax of select statement to address the issue
raised. 
This would provide an appropriate error message to the user if the syntax is wrong.

Fix: Made change in CliDriver.java to make an extra check on the syntax of select statement.


This addresses bug HIVE-3141.
    https://issues.apache.org/jira/browse/HIVE-3141


Diffs
-----

  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 344606c 
  ql/src/test/queries/clientnegative/select_syntax.q PRE-CREATION 
  ql/src/test/results/clientnegative/select_syntax.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/6919/diff/


Testing
-------

Negative Test case: Added select_syntax.q file for negative test.

Test Result: Output of select_syntax.q is available in select_syntax.q.out.


Thanks,

Ajesh kumar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message