Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6ABCADFC9 for ; Mon, 20 Aug 2012 19:03:39 +0000 (UTC) Received: (qmail 70788 invoked by uid 500); 20 Aug 2012 19:03:38 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 70638 invoked by uid 500); 20 Aug 2012 19:03:38 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 70490 invoked by uid 500); 20 Aug 2012 19:03:38 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 70370 invoked by uid 99); 20 Aug 2012 19:03:38 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Aug 2012 19:03:38 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1531F2C5BF9 for ; Mon, 20 Aug 2012 19:03:38 +0000 (UTC) Date: Tue, 21 Aug 2012 06:03:38 +1100 (NCT) From: "Gang Tim Liu (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <1103506189.31324.1345489418087.JavaMail.jiratomcat@arcas> In-Reply-To: <1609973164.22736.1345188998008.JavaMail.jiratomcat@arcas> Subject: [jira] [Updated] (HIVE-3394) Refactor a few classes' constructors with creational patterns MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Tim Liu updated HIVE-3394: ------------------------------- Status: Patch Available (was: In Progress) Patch is available in both jira and phabricator. Some explannations in phabricator. > Refactor a few classes' constructors with creational patterns > ------------------------------------------------------------- > > Key: HIVE-3394 > URL: https://issues.apache.org/jira/browse/HIVE-3394 > Project: Hive > Issue Type: Bug > Reporter: Gang Tim Liu > Assignee: Gang Tim Liu > Priority: Minor > Attachments: HIVE-3394.patch.1, HIVE-3394.patch.2 > > > It's good to refactor the following classes' constructors with builder/factory pattern. This should be done before HIVE-3072 so that HIVE-3072 can refresh according and extend it to skewed use case: > 1. MStorageDescriptor.java > 2. ColumnInfo.java > 3. ParseContext.java > 4. CreateTableDesc.java > 5. ExprNodeColumnDesc.java -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira