hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "namit jain" <nj...@fb.com>
Subject Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records
Date Wed, 22 Aug 2012 10:51:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6650/#review10616
-----------------------------------------------------------



TestHiveMetaTool.launch
<https://reviews.apache.org/r/6650/#comment22716>

    looks like a hard-coded path



metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<https://reviews.apache.org/r/6650/#comment22718>

    Is this a good idea ?
    
    Adding some API's in ObjectStore that are not to be exposed by thrift, and assumes a JDO.



metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<https://reviews.apache.org/r/6650/#comment22717>

    System.out.println() in hive code seems like a bad idea


- namit jain


On Aug. 22, 2012, 2:48 a.m., Shreepadma Venugopalan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6650/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2012, 2:48 a.m.)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Description
> -------
> 
> This patch implement hive metatool which,
> 
> * lets admins perform a HA upgrade by patching the location of the NN in Hive's metastore
> * allows JDOQL to be executed against the metastore.
> 
> Additionally this patch also upgrades DN to 3.0
> 
> 
> This addresses bug HIVE-3056.
>     https://issues.apache.org/jira/browse/HIVE-3056
> 
> 
> Diffs
> -----
> 
>   TestHiveMetaTool.launch PRE-CREATION 
>   bin/ext/metatool.sh PRE-CREATION 
>   bin/metatool PRE-CREATION 
>   build.xml 6712af9 
>   conf/hive-default.xml.template cc1565f 
>   metastore/ivy.xml 3011d2f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 6f4716c 
>   metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java PRE-CREATION

>   metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaTool.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/6650/diff/
> 
> 
> Testing
> -------
> 
> Manual testing for various metatool options.
> 
> 
> Thanks,
> 
> Shreepadma Venugopalan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message