hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-3391) Keep the original query in HiveDriverRunHookContextImpl
Date Mon, 27 Aug 2012 20:21:07 GMT

    [ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442685#comment-13442685
] 

Kevin Wilfong commented on HIVE-3391:
-------------------------------------

Could you add a testcase, e.g. write a driver run hook that prints the command to stdout,
and add a simple unit test which consists of a query using that hook https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-AddaUnitTest

It'll help prevent anyone from accidentally breaking this change.
                
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
>                 Key: HIVE-3391
>                 URL: https://issues.apache.org/jira/browse/HIVE-3391
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Dawid Dabrowski
>            Assignee: Dawid Dabrowski
>            Priority: Minor
>         Attachments: HIVE-3391.1.patch.txt
>
>   Original Estimate: 72h
>          Time Spent: 96h
>  Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed
first is HiveDriverRunHook, let's add it there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message