hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kanna Karanam" <kanna...@microsoft.com>
Subject Review Request: HIVE_3320 : Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
Date Mon, 30 Jul 2012 18:08:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6215/
-----------------------------------------------------------

Review request for hive, Carl Steinbach, Edward  Capriolo, and Ashutosh Chauhan.


Description
-------

Existing functionality in Hive is looking for the “LF” character to extract the lines
from generated output before writing to the streaming object. Whereas in Windows, the line
endings are “CRLF” characters so it is leaving the “CR” character before writing each
line to the streaming object. This CR is introducing the extra empty lines in the generated
test output and causing several test cases to fail on Windows.

Attached the generated output for one of the unit test failures with extra space. (bucket1.q)


This addresses bug HIVE-3320.
    https://issues.apache.org/jira/browse/HIVE-3320


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1367185 

Diff: https://reviews.apache.org/r/6215/diff/


Testing
-------


Thanks,

Kanna Karanam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message