hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kanna Karanam" <kanna...@microsoft.com>
Subject Review Request: Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java.
Date Mon, 30 Jul 2012 16:00:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6213/
-----------------------------------------------------------

Review request for hive, Carl Steinbach, Edward  Capriolo, and Ashutosh Chauhan.


Description
-------

Windows can’t delete the files if there are any open file handles on it so it is required
to close them properly after completing the validation in DosToUnix utilities.


This addresses bug HIVE-3317.
    https://issues.apache.org/jira/browse/HIVE-3317


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/util/DosToUnix.java 1367127 

Diff: https://reviews.apache.org/r/6213/diff/


Testing
-------

Yes


Thanks,

Kanna Karanam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message