hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: Resource Leak: Fix the File handle leak in EximUtil.java
Date Thu, 05 Jul 2012 20:12:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5777/#review8890
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java
<https://reviews.apache.org/r/5777/#comment18935>

    This check is looking for non-absolute paths, but on Windows it will always evaluate to
true. I think this check should be replaced with a call to Path.isAbsolute().



http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java
<https://reviews.apache.org/r/5777/#comment18933>

    This check is looking for non-absolute paths, but on Windows it will always evaluate to
true. I think this check should be replaced with a call to Path.isAbsolute().



http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java
<https://reviews.apache.org/r/5777/#comment18934>

    This logic is no-op unless we're running in testmode, which makes me worry that this may
still be broken on windows if you run it by hand. Can you please check on this? Thanks.


- Carl Steinbach


On July 5, 2012, 7:50 p.m., Kanna Karanam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5777/
> -----------------------------------------------------------
> 
> (Updated July 5, 2012, 7:50 p.m.)
> 
> 
> Review request for hive, Carl Steinbach, Edward  Capriolo, and Ashutosh Chauhan.
> 
> 
> Description
> -------
> 
> 1) Not closing the file handle EximUtil after reading the metadata from the file.
> 2) Nit: Get the path from URI to handle the Windows paths.
> 
> 
> This addresses bug HIVE-3232.
>     https://issues.apache.org/jira/browse/HIVE-3232
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java
1357818 
> 
> Diff: https://reviews.apache.org/r/5777/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Kanna Karanam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message