hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-3092) Hive tests should load Hive classes from build directory, not Ivy cache
Date Thu, 14 Jun 2012 17:04:42 GMT

    [ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295163#comment-13295163
] 

Kevin Wilfong commented on HIVE-3092:
-------------------------------------

Carl did have a good point, this patch did not fix the case where a class is removed.

In my newly uploaded patch, when the test class path is constructed it adds the jars from
build/dist/lib before the Ivy jars, and excludes all hive jars from Ivy.

So now, for the 3 cases Carl mentioned, this patch fixes them for ant test.  It also means
that we can run the tests after running the much faster ant clean rather than ant very-clean.
 Finally, it means that different checkouts won't read their Hive jars from the common Ivy
repo resulting in potentially picking up the changes in another checkout.  Given that, I would
argue that for the case of running the command ant test, this patch is better than the fix
proposed in HIVE-3116, although that has value for other cases.
                
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
>                 Key: HIVE-3092
>                 URL: https://issues.apache.org/jira/browse/HIVE-3092
>             Project: Hive
>          Issue Type: Bug
>          Components: Testing Infrastructure, Tests
>            Reporter: Jakob Homan
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather
from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU).
 This means that absent a very-clean, one is testing against a previous version of the code
and cross-component tests are invalid.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message