hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke" <...@lars-francke.de>
Subject Review Request: HBase Handler doesn't handle NULLs properly
Date Mon, 25 Jun 2012 05:29:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5542/
-----------------------------------------------------------

Review request for hive.


Description
-------

This patch moves the initialization of the fieldsInited variable to the end of the loop because
otherwise NULL values will return stale data on the second iteration. All other cases should
be unaffected by this change. 


This addresses bug HIVE-3179.
    https://issues.apache.org/jira/browse/HIVE-3179


Diffs
-----

  hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java d35bb52 
  hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java f91be4c 

Diff: https://reviews.apache.org/r/5542/diff/


Testing
-------

Debugged problem, added code to existing test to force wrong behavior which is fixed by this
patch, ran the hbase-handler unit tests


Thanks,

Lars Francke


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message