hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-3100: Integrate SQLLine command line editor
Date Mon, 18 Jun 2012 22:52:13 GMT


> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote:
> > LICENSE, line 421
> > <https://reviews.apache.org/r/5381/diff/2/?file=111880#file111880line421>
> >
> >     Please replace with the license text from CVS.
> 
> Prasad Mujumdar wrote:
>     I am still not fully convinced that copying the CVS license is the right way. Here
are following things to consider -
>     1) The source distributions (even 1.0.2) still includes the old license file which
contains GNU license. 
>     2) In fact this license change from GNU to BSD was done in 1.0.2 release, so I am
not sure if that makes 1.0 a GNU license release. Just to be safe, I put a added a workaround
in the ivy script to use 1.0.2. Though on a related note, I am not sure if its possible to
change license from GNU to non-GNU on the same codebase ...
>     3) The binary distributions are not including the license text in CVS repository
in any format, also its not there on the download site. Hence I don't know if this qualifies
to be a license under which Hive is using/redistributing sqlline.
>

> 1) The source distributions (even 1.0.2) still includes the old license file which contains
GNU license. 

See the discussion here: http://old.nabble.com/Bug-491805%3A-RFS%3A-sqlline-td18718027.html

Specifically: 

I've contacted upstream (Marc Prud'hommeaux) about this issue, and he reply to 
me : 
" 
SQLLine was once GPL, but it was changed to be BSD a few years back.   
Any references to the GPL are vestigial. Hopefully the license   
declaration at http://sqlline.sourceforge.net/#license is sufficiently   
authoritative in this regard. 
" 

> Though on a related note, I am not sure if its possible to change license from GNU to
non-GNU on the same codebase

The original copyright holder (in this case Mr. Prud'hommeaux) can do whatever he wants. See
http://stackoverflow.com/questions/1077668/can-i-change-my-open-source-license-from-licensea-to-licenseb

> The binary distributions are not including the license text in CVS repository in any
format, also its not there on the download site. Hence I don't know if this qualifies to be
a license under which Hive is using/redistributing sqlline.

Ok, then let's copy what the Ubuntu maintainers have done: https://launchpad.net/ubuntu/jaunty/+source/sqlline/+copyright


---------------------------------------
For the SQLLine library:

Copyright (c) 2002, 2003, 2004, 2005 Marc Prud'hommeaux

From: http://sqlline.sourceforge.net/#license

"SQLLine is distributed under the BSD License, meaning that you are free to redistribute,
modify, or sell the software with almost no restrictions."

Statement from Marc Prud'hommeaux regarding inconsistent licenses in some SQLLine source files:

> SQLLine was once GPL, but it was changed to be BSD a few years back.
> Any references to the GPL are vestigial. Hopefully the license
> declaration at http://sqlline.sourceforge.net/#license is sufficiently
> authoritative in this regard.
----------------------------------------


- Carl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/#review8346
-----------------------------------------------------------


On June 18, 2012, 6:19 p.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5381/
> -----------------------------------------------------------
> 
> (Updated June 18, 2012, 6:19 p.m.)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Description
> -------
> 
> The patch is to include command line SQL editor SQLLine into Hive distribution. The tool
can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer
running on the given host/port.
> 
> The ivy dependencies are updated to include sqlline. The hive scripts are updated to
executing SQLLine with the required connection URL and other command line options. The LICENSE
and NOTICE files are updated to include SQLLine information.
> 
> 
> Diffs
> -----
> 
>   LICENSE 05085da 
>   NOTICE 871fdde 
>   bin/ext/sqlline.sh PRE-CREATION 
>   cli/ivy.xml ab949b1 
>   ivy/ivysettings.xml fb6f4b8 
>   ivy/libraries.properties 8461da1 
> 
> Diff: https://reviews.apache.org/r/5381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message