hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-3100: Integrate SQLLine command line editor
Date Mon, 18 Jun 2012 19:36:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/#review8346
-----------------------------------------------------------


I think it's important to get local mode working and also put a Java wrapper in place before
committing this.


LICENSE
<https://reviews.apache.org/r/5381/#comment17992>

    Please replace with the license text from CVS.



bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17994>

    Missing "[db]". Also, this is what sqlline_help() should print.



bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17999>

    Would you mind changing the name to "beeline"? That was the name John used in his original
patch and I think it's kind of cute.



bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17997>

    Please use getopts (http://rsalveti.wordpress.com/2007/04/03/bash-parsing-arguments-with-getopts/)
or delegate command line option handling to a Java wrapper. The latter option is preferred
since it's more portable and is arguably less fragile.



bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17995>

    Where is execSQLLine defined?



bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17996>

    The help options that get dumped here are inaccessible from the command line. 



cli/ivy.xml
<https://reviews.apache.org/r/5381/#comment18000>

    I think it probably makes more sense for this to be a dependency on the hive-jdbc module.
Otherwise we also need to add a hive-jdbc dependency to hive-cli which is something I would
rather avoid.
    
    On a related note, the BeeLine wrapper and command processor also belongs in the hive-jdbc
module.


- Carl Steinbach


On June 18, 2012, 6:19 p.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5381/
> -----------------------------------------------------------
> 
> (Updated June 18, 2012, 6:19 p.m.)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Description
> -------
> 
> The patch is to include command line SQL editor SQLLine into Hive distribution. The tool
can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer
running on the given host/port.
> 
> The ivy dependencies are updated to include sqlline. The hive scripts are updated to
executing SQLLine with the required connection URL and other command line options. The LICENSE
and NOTICE files are updated to include SQLLine information.
> 
> 
> Diffs
> -----
> 
>   LICENSE 05085da 
>   NOTICE 871fdde 
>   bin/ext/sqlline.sh PRE-CREATION 
>   cli/ivy.xml ab949b1 
>   ivy/ivysettings.xml fb6f4b8 
>   ivy/libraries.properties 8461da1 
> 
> Diff: https://reviews.apache.org/r/5381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message