hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-3114) Split Thrift interface for Table Link Creation
Date Tue, 12 Jun 2012 01:38:43 GMT

    [ https://issues.apache.org/jira/browse/HIVE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293261#comment-13293261
] 

Carl Steinbach edited comment on HIVE-3114 at 6/12/12 1:37 AM:
---------------------------------------------------------------

bq. Agreed it was a mistake for unclean thrift API. But, we cannot penalize a single feature,
which we need urgently, for that. I am all for the thrift cleanup - it is just that the timing
is not right from our side.

I'm not asking you to clean up the entire metastore Thrift API. All I'm asking is for you
to add a createTableLink() method instead of overloading the createTable() method. It's fine
if both createTable() and createTableLink() use a common codepath behind the Thrift API, but
the Thrift API needs to call these things out as distinct operations.

bq. @Bhushan, in the links wiki - can you add a follow-up for the thrift interface ?

When are these followups going to be addressed? If they aren't committed in time for the 0.10.0
release are you OK with us backing out these changes?
                
      was (Author: cwsteinbach):
    bq. Agreed it was a mistake for unclean thrift API. But, we cannot penalize a single feature,
which we need urgently, for that.
I am all for the thrift cleanup - it is just that the timing is not right from our side.

I'm not asking you to clean up the entire metastore Thrift API. All I'm asking is for you
to add a createTableLink() method instead of overloading the createTable() method. It's fine
if both createTable() and createTableLink() use a common codepath behind the Thrift API, but
the Thrift API needs to call these things out as distinct operations.

bq. @Bhushan, in the links wiki - can you add a follow-up for the thrift interface ?

When are these followups going to be addressed? If they aren't committed in time for the 0.10.0
release are you OK with us backing out these changes?
                  
> Split Thrift interface for Table Link Creation
> ----------------------------------------------
>
>                 Key: HIVE-3114
>                 URL: https://issues.apache.org/jira/browse/HIVE-3114
>             Project: Hive
>          Issue Type: New Feature
>    Affects Versions: 0.10.0
>            Reporter: Bhushan Mandhani
>            Assignee: Bhushan Mandhani
>            Priority: Minor
>
> Table Link creation through Thrift currently goes through the same method as Table creation.
We want to move it out of there and into it's own method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message