hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-3101) dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
Date Fri, 08 Jun 2012 14:52:23 GMT

    [ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291809#comment-13291809
] 

Edward Capriolo commented on HIVE-3101:
---------------------------------------

Can we create a unit test around this? Hooks should print during testing and then we have
some coverage here.
                
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3101
>                 URL: https://issues.apache.org/jira/browse/HIVE-3101
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: ransom.hezhiqiang
>            Assignee: ransom.hezhiqiang
>         Attachments: HIVE-3101.1.patch
>
>
> see  the codes:
>  boolean success = false;
>     try {
>       client.drop_table(dbname, name, deleteData);
>       if (hook != null) {
>         hook.commitDropTable(tbl, deleteData);
>       }
>     } catch (NoSuchObjectException e) {
>       if (!ignoreUknownTab) {
>         throw e;
>       }
>     } finally {
>       if (!success && (hook != null)) {
>         hook.rollbackDropTable(tbl);
>       }
>     }
> success  will always false, whether  the drop was success or faild.
> so it's a bug. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message