hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <pras...@cloudera.com>
Subject Review Request: HIVE-3034: Implement [INCLUDE|EXCLUDE]_IF_SYS_PROP_DEFINED() test macro
Date Thu, 24 May 2012 21:30:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5227/
-----------------------------------------------------------

Review request for hive and Carl Steinbach.


Summary
-------

Support include/exclude macros in the test and build property to trigger inclusion or exclusion
of the test based on the macros.
The test macro is of the format [EX|IN]CLUDE_IF_TEST_PROP_DEFINED(property,val1,val2,...)
This will cause the test to be include or excluded based on the test.include.property or test.exclude.property
passed to the build command line. For example,
test101.q -
 -- EXCLUDE_IF_TEST_PROP_DEFINED(fooProp, 100)
..
ant -Dtest.exclude.property="foo:100" test

This will cause the test run to exclude the test101.q script


This addresses bug HIVE-3034.
    https://issues.apache.org/jira/browse/HIVE-3034


Diffs
-----

  build-common.xml b2135b3 
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 93d002a 
  ql/src/test/queries/clientpositive/join91.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join91.q.out PRE-CREATION 
  ql/src/test/queries/clientpositive/join92.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join99.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join99.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/5227/diff


Testing
-------

Added dummy test that use the new macro


Thanks,

Prasad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message