Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Received-SPF: pass (nike.apache.org: domain of kevinwilfong@fb.com designates
 67.231.153.30 as permitted sender)
From: Kevin Wilfong <kevinwilfong@fb.com>
To: Carl Steinbach <carl@cloudera.com>, "jvs@apache.org" <jvs@apache.org>
CC: "dev@hive.apache.org" <dev@hive.apache.org>
Subject: Re: Problems with Arc/Phabricator
Thread-Topic: Problems with Arc/Phabricator
Thread-Index: AQHNF3wc92PFLeWPs0a6wHWc0Wb1+paUzZQAgAB4owD//4+DAA==
Date: Wed, 11 Apr 2012 01:27:47 +0000
Message-ID: <CBAA28FF.10A5D%kevinwilfong@fb.com>
In-Reply-To: 
 <CAJqeMKTh32s1b+PmbU2Zd8zufyGxuTyw=OXJoRqbZhq5wXB4xA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: multipart/alternative;
	boundary="_000_CBAA28FF10A5Dkevinwilfongfbcom_"
MIME-Version: 1.0

--_000_CBAA28FF10A5Dkevinwilfongfbcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

+John Sichi as he did a lot of the work on getting Hive to use Phabricator.

Is there anything preventing people from using Review Board for patches now=
, except maybe convention?  As for applying patches, in either case, you ca=
n download the patch from the JIRA site.

To be clear, I am not trying to aggressively force Phabricator on Hive, the=
se are just suggestions.

From: Carl Steinbach <carl@cloudera.com<mailto:carl@cloudera.com>>
Date: Tue, 10 Apr 2012 18:10:44 -0700
To: Microsoft Office User <kevinwilfong@fb.com<mailto:kevinwilfong@fb.com>>
Cc: "dev@hive.apache.org<mailto:dev@hive.apache.org>" <dev@hive.apache.org<=
mailto:dev@hive.apache.org>>
Subject: Re: Problems with Arc/Phabricator

Ok, I'll submit an issue. But then what? Who is going to fix it? Perhaps in=
 the meantime we should just switch back to using reviewboard while we wait=
 for Arc and Phabricator to mature as open source projects.


On Tue, Apr 10, 2012 at 5:58 PM, Kevin Wilfong <kevinwilfong@fb.com<mailto:=
kevinwilfong@fb.com>> wrote:
There's a list of ways to report issues/get help on the side bar of this
site http://phabricator.org/

It suggests #phabricator <irc://chat.freenode.net/phabricator<http://chat.f=
reenode.net/phabricator>> as the best
place to get help with issues.

On 4/10/12 5:42 PM, "Carl Steinbach" <carl@cloudera.com<mailto:carl@clouder=
a.com>> wrote:

>Arc won't let me apply the patch for HIVE-2646. I've also noticed some
>other problems (e.g. missing TEST PLAN in checkin comments), and was
>wondering how we can get these problems resolved? Since most of this work
>was done at Facebook, who is the designated point of contact for
>Arc/Phabricator issues going forward?
>
>
>Here's the error I get when applying HIVE-2646:
>
>% arc patch D2133 --trace
>Loading phutil library 'arc_jira_lib' from
>'/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>>>> [0] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>--show-cdup)
><<< [0] <exec> 13,599 us
>>>> [1] <conduit> differential.getdiff()
><<< [1] <conduit> 608,237 us
>>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git apply
>>>>--index
>--reject)
><<< [2] <exec> 13,178 us
>
>Fatal error: Uncaught exception 'CommandException' with message 'Command
>'(cd '/Users/carl/Work/repos/hive-test/'; git apply --index --reject)'
>failed with error #128:
>stdout:
>
>stderr:
><stdin>:10: trailing whitespace.
>
><stdin>:111: trailing whitespace.
>    <fileset dir=3D"${build.ivy.lib.dir}/default" includes=3D"*.jar"
>fatal: corrupt patch at line 609
>
>' in /Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php:346
>Stack trace:
>#0
>/Users/carl/.local/pkg/arcanist/src/workflow/patch/ArcanistPatchWorkflow.p
>hp(412):
>ExecFuture->resolvex()
>#1 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(266):
>ArcanistPatchWorkflow->run()
>#2 {main}
>  thrown in
>/Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php
>on line 346
>
>
>Thanks.
>
>Carl


--_000_CBAA28FF10A5Dkevinwilfongfbcom_--