hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sichi <jsi...@gmail.com>
Subject Re: Problems with Arc/Phabricator
Date Wed, 11 Apr 2012 02:22:30 GMT
For HIVE-2646:  the diagnostics aren't great, but I think it's just
choking on a patch that needs to be rebased, since as Kevin says, if I
download the latest .patch from JIRA and apply that with patch -p0, I
get the correct failure message.  So just ask the author to rebase
again?

Regarding the test plans:  Carl, could you be more specific about what
is going wrong so I can attempt to reproduce the problem?

JVS

On Tue, Apr 10, 2012 at 6:27 PM, Kevin Wilfong <kevinwilfong@fb.com> wrote:
> +John Sichi as he did a lot of the work on getting Hive to use Phabricator.
>
> Is there anything preventing people from using Review Board for patches now,
> except maybe convention?  As for applying patches, in either case, you can
> download the patch from the JIRA site.
>
> To be clear, I am not trying to aggressively force Phabricator on Hive,
> these are just suggestions.
>
> From: Carl Steinbach <carl@cloudera.com>
> Date: Tue, 10 Apr 2012 18:10:44 -0700
> To: Microsoft Office User <kevinwilfong@fb.com>
> Cc: "dev@hive.apache.org" <dev@hive.apache.org>
> Subject: Re: Problems with Arc/Phabricator
>
> Ok, I'll submit an issue. But then what? Who is going to fix it? Perhaps in
> the meantime we should just switch back to using reviewboard while we wait
> for Arc and Phabricator to mature as open source projects.
>
>
> On Tue, Apr 10, 2012 at 5:58 PM, Kevin Wilfong <kevinwilfong@fb.com> wrote:
>>
>> There's a list of ways to report issues/get help on the side bar of this
>> site http://phabricator.org/
>>
>> It suggests #phabricator <irc://chat.freenode.net/phabricator> as the best
>> place to get help with issues.
>>
>> On 4/10/12 5:42 PM, "Carl Steinbach" <carl@cloudera.com> wrote:
>>
>> >Arc won't let me apply the patch for HIVE-2646. I've also noticed some
>> >other problems (e.g. missing TEST PLAN in checkin comments), and was
>> >wondering how we can get these problems resolved? Since most of this work
>> >was done at Facebook, who is the designated point of contact for
>> >Arc/Phabricator issues going forward?
>> >
>> >
>> >Here's the error I get when applying HIVE-2646:
>> >
>> >% arc patch D2133 --trace
>> >Loading phutil library 'arc_jira_lib' from
>> >'/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>> >>>> [0] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>> >--show-cdup)
>> ><<< [0] <exec> 13,599 us
>> >>>> [1] <conduit> differential.getdiff()
>> ><<< [1] <conduit> 608,237 us
>> >>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git
apply
>> >>>>--index
>> >--reject)
>> ><<< [2] <exec> 13,178 us
>> >
>> >Fatal error: Uncaught exception 'CommandException' with message 'Command
>> >'(cd '/Users/carl/Work/repos/hive-test/'; git apply --index --reject)'
>> >failed with error #128:
>> >stdout:
>> >
>> >stderr:
>> ><stdin>:10: trailing whitespace.
>> >
>> ><stdin>:111: trailing whitespace.
>> >    <fileset dir="${build.ivy.lib.dir}/default" includes="*.jar"
>> >fatal: corrupt patch at line 609
>> >
>> >' in /Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php:346
>> >Stack trace:
>> >#0
>>
>> > >/Users/carl/.local/pkg/arcanist/src/workflow/patch/ArcanistPatchWorkflow.p
>> >hp(412):
>> >ExecFuture->resolvex()
>> >#1 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(266):
>> >ArcanistPatchWorkflow->run()
>> >#2 {main}
>> >  thrown in
>> >/Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php
>> >on line 346
>> >
>> >
>> >Thanks.
>> >
>> >Carl
>>
>

Mime
View raw message