hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2646) Hive Ivy dependencies on Hadoop should depend on jars directly, not tarballs
Date Mon, 16 Apr 2012 23:10:18 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255173#comment-13255173
] 

Phabricator commented on HIVE-2646:
-----------------------------------

cwsteinbach has commented on the revision "HIVE-2646 [jira] Hive Ivy dependencies on Hadoop
should depend on jars directly, not tarballs".

  alter_table_wrong_regex and create_table_wrong_regex both belong in contrib/src/test/queries/clientnegative/.
It was a mistake in the first place for them to get committed to the ql directory since nothing
else in Hive is supposed to have a dependency on contrib (which is pretty much the whole point
of contrib).

  The same thing goes for udfnull.q. The point of this test (which you would never be able
to tell by looking at it since the original author failed to include any documentation) is
that query execution will fail (despite query compilation succeeding) if the query references
a UDF which is on the local classpath but not on the cluster classpath, which usually happens
when the user forgets to include an 'ADD JAR ...' statement. In order to get this test to
pass we need to ensure that hive-contrib*.jar is not on bin/hadoop's classpath.

REVISION DETAIL
  https://reviews.facebook.net/D2133

                
> Hive Ivy dependencies on Hadoop should depend on jars directly, not tarballs
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2646
>                 URL: https://issues.apache.org/jira/browse/HIVE-2646
>             Project: Hive
>          Issue Type: Bug
>          Components: Build Infrastructure
>    Affects Versions: 0.8.0
>            Reporter: Andrew Bayer
>            Assignee: Andrew Bayer
>            Priority: Critical
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2646.D2133.1.patch, HIVE-2646.D2133.10.patch, HIVE-2646.D2133.11.patch,
HIVE-2646.D2133.12.patch, HIVE-2646.D2133.13.patch, HIVE-2646.D2133.14.patch, HIVE-2646.D2133.15.patch,
HIVE-2646.D2133.2.patch, HIVE-2646.D2133.3.patch, HIVE-2646.D2133.4.patch, HIVE-2646.D2133.5.patch,
HIVE-2646.D2133.6.patch, HIVE-2646.D2133.7.patch, HIVE-2646.D2133.8.patch, HIVE-2646.D2133.9.patch,
HIVE-2646.diff.txt
>
>
> The current Hive Ivy dependency logic for its Hadoop dependencies is problematic - depending
on the tarball and extracting the jars from there, rather than depending on the jars directly.
It'd be great if this was fixed to actually have the jar dependencies defined directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message