hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-2848) Add validation to HiveConf ConfVars
Date Mon, 02 Apr 2012 23:43:25 GMT

     [ https://issues.apache.org/jira/browse/HIVE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HIVE-2848:
------------------------------

    Attachment: HIVE-2848.D2313.3.patch

navis updated the revision "HIVE-2848 [jira] Add validation to HiveConf ConfVars".
Reviewers: JIRA

  1. Enum-ed configuration type.
  2. Removed checking existence of "hive.~" configurations.
  3. Fixed test-case bugs in udaf_context_ngrams.q, udaf_ngrams.q and udaf_percentile_approx.q
after applying validation.

  except 3, passed all tests.

REVISION DETAIL
  https://reviews.facebook.net/D2313

AFFECTED FILES
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
  ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
  ql/src/test/queries/clientnegative/set_hiveconf_validation0.q
  ql/src/test/queries/clientnegative/set_hiveconf_validation1.q
  ql/src/test/queries/clientpositive/udaf_context_ngrams.q
  ql/src/test/queries/clientpositive/udaf_ngrams.q
  ql/src/test/queries/clientpositive/udaf_percentile_approx.q
  ql/src/test/results/clientnegative/set_hiveconf_validation0.q.out
  ql/src/test/results/clientnegative/set_hiveconf_validation1.q.out
  ql/src/test/results/clientpositive/udaf_context_ngrams.q.out
  ql/src/test/results/clientpositive/udaf_ngrams.q.out
  ql/src/test/results/clientpositive/udaf_percentile_approx.q.out

                
> Add validation to HiveConf ConfVars
> -----------------------------------
>
>                 Key: HIVE-2848
>                 URL: https://issues.apache.org/jira/browse/HIVE-2848
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.9.0
>            Reporter: Kevin Wilfong
>            Assignee: Navis
>         Attachments: HIVE-2848.D2313.1.patch, HIVE-2848.D2313.2.patch, HIVE-2848.D2313.3.patch
>
>
> It would be good if we could add some validation to ConfVars in the HiveConf when they
are set.
> At least if a variable is supposed to be boolean, numeric, or strict/nonstrict, it shouldn't
be too difficult to check for these.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message