hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-2960) Stop testing concat of partitions containing control characters.
Date Tue, 17 Apr 2012 23:54:17 GMT

     [ https://issues.apache.org/jira/browse/HIVE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HIVE-2960:
------------------------------

    Attachment: HIVE-2960.D2865.1.patch

kevinwilfong requested code review of "HIVE-2960 [jira] Stop testing concat of partitions
containing control characters.".
Reviewers: JIRA

  https://issues.apache.org/jira/browse/HIVE-2960

  Remove the testcases for concatenating partitions containing control characters.

  We have been, for a short while, testing to make sure that concatenation commands work with
partitions that contain ASCII control characters.  This happened to work up until recently
due to a happy coincidence in the way the Hive object's HiveConf was updated.  Namely, it
was updated often enough that it got configs set by the user, but not so often that it got
the value for hive.query.string.  With some recent changes, it now needs to be updated more
often, see https://issues.apache.org/jira/browse/HIVE-2918

  This breaks the process of launching a job to merge partitions that contain ASCII control
characters.  The job conf is constructed using the updated Hive conf containing the value
of hive.query.string which contains ASCII control characters.  When the job conf is converted
to XML it fails because these characters are illegal.  Given that any query has, even prior
to this change, failed when that query contained ASCII control characters, and hence these
partitions cannot be queried directly, it seems reasonable to no longer support concatenating
them either (which this change will allow for).

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2865

AFFECTED FILES
  ql/src/test/results/clientpositive/escape2.q.out
  ql/src/test/queries/clientpositive/escape2.q

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6501/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Stop testing concat of partitions containing control characters.
> ----------------------------------------------------------------
>
>                 Key: HIVE-2960
>                 URL: https://issues.apache.org/jira/browse/HIVE-2960
>             Project: Hive
>          Issue Type: Test
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2960.D2865.1.patch
>
>
> We have been, for a short while, testing to make sure that concatenation commands work
with partitions that contain ASCII control characters.  This happened to work up until recently
due to a happy coincidence in the way the Hive object's HiveConf was updated.  Namely, it
was updated often enough that it got configs set by the user, but not so often that it got
the value for hive.query.string.  With some recent changes, it now needs to be updated more
often, see https://issues.apache.org/jira/browse/HIVE-2918
> This breaks the process of launching a job to merge partitions that contain ASCII control
characters.  The job conf is constructed using the updated Hive conf containing the value
of hive.query.string which contains ASCII control characters.  When the job conf is converted
to XML it fails because these characters are illegal.  Given that any query has, even prior
to this change, failed when that query contained ASCII control characters, and hence these
partitions cannot be queried directly, it seems reasonable to no longer support concatenating
them either (which this change will allow for).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message