hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2936) Warehouse table subdirectories should inherit the group permissions of the warehouse parent directory
Date Thu, 12 Apr 2012 23:53:18 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252981#comment-13252981
] 

Ashutosh Chauhan commented on HIVE-2936:
----------------------------------------

Looks good, couple of comments:
* I dont see a need of parent existence check, parent will always exists. / is parent of itself.
* fs.mkdirs() takes permission as an argument, so use that signature instead of first creating
dirs and then setting perms. 

So, something like following:
{code}
 boolean success;
      if (this.inheritPerms) {
        success = fs.mkdirs(f, fs.getFileStatus(f.getParent()).getPermission());
      } else {
        success = fs.mkdirs(f);
      }
      return success;
{code}
                
> Warehouse table subdirectories should inherit the group permissions of the warehouse
parent directory
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2936
>                 URL: https://issues.apache.org/jira/browse/HIVE-2936
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>            Reporter: Rohini Palaniswamy
>            Assignee: Rohini Palaniswamy
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2504-1.patch, HIVE-2504.patch, HIVE-2504.patch
>
>
> When the Hive Metastore creates a subdirectory in the Hive warehouse for
> a new table it does so with the default HDFS permissions derived from dfs.umask or dfs.umaskmode.
There should be a option to inherit the permissions of the parent directory (default warehouse
or custom database directory) so that the table directories have the same permissions as the
database directories. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message