Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F35789203 for ; Fri, 16 Mar 2012 00:41:00 +0000 (UTC) Received: (qmail 67013 invoked by uid 500); 16 Mar 2012 00:41:00 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 66954 invoked by uid 500); 16 Mar 2012 00:41:00 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 66946 invoked by uid 500); 16 Mar 2012 00:41:00 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 66943 invoked by uid 99); 16 Mar 2012 00:41:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Mar 2012 00:41:00 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Mar 2012 00:40:59 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2264C21898 for ; Fri, 16 Mar 2012 00:40:39 +0000 (UTC) Date: Fri, 16 Mar 2012 00:40:39 +0000 (UTC) From: "Phabricator (Updated) (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <1946898661.22353.1331858439142.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <730300005.19884.1331834020616.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HIVE-2871) Add a new hook to run at the beginning and end of the Driver.run method MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HIVE-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HIVE-2871: ------------------------------ Attachment: HIVE-2871.D2331.3.patch kevinwilfong updated the revision "HIVE-2871 [jira] Add a new hook to run at the beginning and end of the Driver.run method". Reviewers: JIRA, njain So sorry about that, my eclipse tends to remove imports if I haven't setup the build path properly. Ran ant clean package, so it should be good. REVISION DETAIL https://reviews.facebook.net/D2331 AFFECTED FILES conf/hive-default.xml.template common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ql/src/test/results/clientpositive/hook_order.q.out ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyHooksRunInOrder.java ql/src/test/queries/clientpositive/hook_order.q ql/src/java/org/apache/hadoop/hive/ql/HiveDriverRunHook.java ql/src/java/org/apache/hadoop/hive/ql/HiveDriverRunHookContextImpl.java ql/src/java/org/apache/hadoop/hive/ql/HiveDriverRunHookContext.java ql/src/java/org/apache/hadoop/hive/ql/Driver.java > Add a new hook to run at the beginning and end of the Driver.run method > ----------------------------------------------------------------------- > > Key: HIVE-2871 > URL: https://issues.apache.org/jira/browse/HIVE-2871 > Project: Hive > Issue Type: Improvement > Reporter: Kevin Wilfong > Assignee: Kevin Wilfong > Attachments: HIVE-2871.D2331.1.patch, HIVE-2871.D2331.2.patch, HIVE-2871.D2331.3.patch > > > Driver.run is the highest level method which all queries go through, whether they come from Hive Server, the CLI, or any other entry. We also do not have any hooks before the compilation method is called, and having hooks in Driver.run would provide this. Having hooks in Driver.run will allow, for example, being able to overwrite config values used throughout query processing, including compilation, and at the other end, cleaning up any resources/logging any final values just before returning to the user. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira