hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <>
Subject [jira] [Commented] (HIVE-2764) Obtain delegation tokens for MR jobs in secure hbase setup
Date Wed, 21 Mar 2012 22:23:39 GMT


Phabricator commented on HIVE-2764:

ashutoshc has requested changes to the revision "HIVE-2764 [jira] Obtain delegation tokens
for MR jobs in secure hbase setup".

  Added comments. Also, patch needs to be rebased.

I understand from this patch that checkOutputSpecs() is never called. But, see an existing
impl here. So, then before this patch, this code was never getting invoked ?
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/ I don't
think you want to override this function and leave a no-op here. I think you still want super-class
checkOS to be called. Isn't it ?
  ql/src/java/org/apache/hadoop/hive/ql/io/ This is not supposed
to get called, right ? In that case this should throw exception, instead of creating object
and returning it.
  ql/src/java/org/apache/hadoop/hive/ql/io/ I dont' see any
use of this, you can as well keep it in local variable in checkOS()
  ql/src/java/org/apache/hadoop/hive/ql/io/ Instead of throwing
Runtime, you should throw IOException which method signature allows you to do.
  ql/src/java/org/apache/hadoop/hive/ql/exec/ This results in setting of
NullOF in all the shims. We should no longer do that, since we are resetting it again in following
  ql/src/java/org/apache/hadoop/hive/ql/exec/ Is this null check
necessary? At the time, checkOS is called, hiveOF would already have been initialized, no?
  ql/src/java/org/apache/hadoop/hive/ql/io/ Looks
like this import statement inadvertently got added.
  ql/src/java/org/apache/hadoop/hive/ql/exec/ To maintain backward-compat
you should first check whether hiveOF has the method checkOS, and call it only if it has.



> Obtain delegation tokens for MR jobs in secure hbase setup  
> ------------------------------------------------------------
>                 Key: HIVE-2764
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>          Components: HBase Handler, Security
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>         Attachments: HIVE-2764.D2205.1.patch, HIVE-2764.D2205.2.patch, HIVE-2764_v0.patch
> As discussed in HCATALOG-244, in a secure hbase setup with 0.92, we need to obtain delegation
tokens for hbase and save it in jobconf, so that tasks can access region servers. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message