hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2764) Obtain delegation tokens for MR jobs in secure hbase setup
Date Wed, 21 Mar 2012 22:23:39 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235106#comment-13235106
] 

Phabricator commented on HIVE-2764:
-----------------------------------

ashutoshc has requested changes to the revision "HIVE-2764 [jira] Obtain delegation tokens
for MR jobs in secure hbase setup".

  Added comments. Also, patch needs to be rebased.

INLINE COMMENTS
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableOutputFormat.java:104
I understand from this patch that checkOutputSpecs() is never called. But, see an existing
impl here. So, then before this patch, this code was never getting invoked ?
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java:214 I don't
think you want to override this function and leave a no-op here. I think you still want super-class
checkOS to be called. Isn't it ?
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveOutputFormatImpl.java:53 This is not supposed
to get called, right ? In that case this should throw exception, instead of creating object
and returning it.
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveOutputFormatImpl.java:45-49 I dont' see any
use of this, you can as well keep it in local variable in checkOS()
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveOutputFormatImpl.java:75 Instead of throwing
Runtime, you should throw IOException which method signature allows you to do.
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java:268 This results in setting of
NullOF in all the shims. We should no longer do that, since we are resetting it again in following
line.
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java:769 Is this null check
necessary? At the time, checkOS is called, hiveOF would already have been initialized, no?
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveNullValueSequenceFileOutputFormat.java:27 Looks
like this import statement inadvertently got added.
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java:781 To maintain backward-compat
you should first check whether hiveOF has the method checkOS, and call it only if it has.

REVISION DETAIL
  https://reviews.facebook.net/D2205

BRANCH
  hbase-dt-of

                
> Obtain delegation tokens for MR jobs in secure hbase setup  
> ------------------------------------------------------------
>
>                 Key: HIVE-2764
>                 URL: https://issues.apache.org/jira/browse/HIVE-2764
>             Project: Hive
>          Issue Type: Improvement
>          Components: HBase Handler, Security
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>         Attachments: HIVE-2764.D2205.1.patch, HIVE-2764.D2205.2.patch, HIVE-2764_v0.patch
>
>
> As discussed in HCATALOG-244, in a secure hbase setup with 0.92, we need to obtain delegation
tokens for hbase and save it in jobconf, so that tasks can access region servers. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message