hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2833) Fix test failures caused by HIVE-2716
Date Fri, 02 Mar 2012 22:44:55 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221326#comment-13221326
] 

Kevin Wilfong commented on HIVE-2833:
-------------------------------------

kevinwilfong requested code review of "HIVE-2716 [jira] Move retry logic in HiveMetaStore
to a separe class".
Reviewers: JIRA

This fixes the issue where the implementation of RawStore was being initialized in the metastore
before the JDOConnectionURLHook was being called. I moved some code around so that the RawStore
implementation is initialized in the RetryRawStore initialization after the hook is called.
In addition, the URL now needs to be updated in the thread local configuration instead of
the non-thread local one, as by the time the hook is now being called, the thread local configuration
has already been initialized based on the other.

In HIVE-1219, method retrying for raw store operation are introduced to handle jdo operations
more robustly. However, the abstraction for the RawStore operations can be moved to a separate
class implementing RawStore, which should clean up the code base for HiveMetaStore.

TEST PLAN
EMPTY

REVISION DETAIL
https://reviews.facebook.net/D2055

AFFECTED FILES
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java
metastore/src/test/org/apache/hadoop/hive/metastore/DummyJdoConnectionUrlHook.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingRawStore.java

MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4407/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.
                
> Fix test failures caused by HIVE-2716
> -------------------------------------
>
>                 Key: HIVE-2833
>                 URL: https://issues.apache.org/jira/browse/HIVE-2833
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Carl Steinbach
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2716.D2055.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message