hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client available to HMSHandler.
Date Tue, 20 Mar 2012 22:41:44 GMT

     [ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HIVE-2797:
------------------------------

    Attachment: HIVE-2797.D1701.5.patch

kevinwilfong updated the revision "HIVE-2797 [jira] Make the IP address of a Thrift client
available to HMSHandler.".
Reviewers: JIRA, njain, ashutoshc

  Really sorry about that Ashutosh.  The TUGIContainingTranspport does not extend TSocket,
which caused the errors you saw.  I added a getSocket method to the class which returns the
Socket object if the underlying TTransport is an instance of TSocket, otherwise null.  TUGIBasedProcessor's
implementation of setIpAddress now uses this method and handles the case of null.

REVISION DETAIL
  https://reviews.facebook.net/D1701

AFFECTED FILES
  shims/src/common/java/org/apache/hadoop/hive/thrift/TUGIContainingTransport.java
  metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java
  metastore/src/test/org/apache/hadoop/hive/metastore/IpAddressListener.java
  metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
  metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java
  metastore/src/java/org/apache/hadoop/hive/metastore/TSetIpAddressProcessor.java
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java

                
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
>                 Key: HIVE-2797
>                 URL: https://issues.apache.org/jira/browse/HIVE-2797
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch,
HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point
of view, anonymous.  If we expose the IP address of the Thrift client to the HMSHandler from
the Processor, this will help to give some context, in particular for audit logging, of where
the call is coming from.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message