hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-1444) "hdfs" is hardcoded in few places in the code which inhibits use of other file systems
Date Wed, 22 Feb 2012 01:24:51 GMT

     [ https://issues.apache.org/jira/browse/HIVE-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HIVE-1444:
------------------------------

    Attachment: HIVE-1444.D1839.1.patch

edwardcapriolo requested code review of "HIVE-1444 [jira] "hdfs" is hardcoded in few places
in the code which inhibits use of other file systems".
Reviewers: JIRA

  https://issues.apache.org/jira/browse/HIVE-1444

  Allows other fs implementations then HDFS

  In quite a few places "hdfs" is hardcoded, which is OK for majority of the cases, except
when it is not really hdfs, but s3 or any other file system.

  The place where it really breaks is:
  in ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java :

  method: private void applyConstraints(URI fromURI, URI toURI, Tree ast, boolean isLocal)

  First few lines are check for file system:
      if (!fromURI.getScheme().equals("file")
          && !fromURI.getScheme().equals("hdfs")) {
        throw new SemanticException(ErrorMsg.INVALID_PATH.getMsg(ast,
            "only \"file\" or \"hdfs\" file systems accepted"));
      }

  "hdfs" is hardcoded.

  I don't think you need to have this check at all as you are checking whether filesystem
is local or not later on anyway and in regards to non locla file system - if one would be
bad one you would get problems or have it look like local before you even come to "applyConstraints"
method.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D1839

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/3909/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> "hdfs" is hardcoded in few places in the code which inhibits use of other file systems
> --------------------------------------------------------------------------------------
>
>                 Key: HIVE-1444
>                 URL: https://issues.apache.org/jira/browse/HIVE-1444
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0, 0.4.0, 0.4.1, 0.5.0, 0.6.0, 0.7.0
>         Environment: any
>            Reporter: Yuliya Feldman
>            Assignee: Edward Capriolo
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: HIVE-1444.D1839.1.patch, hive-1444.patch.txt
>
>
> In quite a few places "hdfs" is hardcoded, which is OK for majority of the cases, except
when it is not really hdfs, but s3 or any other file system.
> The place where it really breaks is:
> in ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java :
> method: private void applyConstraints(URI fromURI, URI toURI, Tree ast, boolean isLocal)
> First few lines are check for file system:
>     if (!fromURI.getScheme().equals("file")
>         && !fromURI.getScheme().equals("hdfs")) {
>       throw new SemanticException(ErrorMsg.INVALID_PATH.getMsg(ast,
>           "only \"file\" or \"hdfs\" file systems accepted"));
>     }
> "hdfs" is hardcoded. 
> I don't think you need to have this check at all as you are checking whether filesystem
is local or not later on anyway and in regards to non locla file system - if one would be
bad one you would get problems or have it look like local before you even come to "applyConstraints"
method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message