hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2813) Throw a Hive error if we're in strict mode and a the types of a partition comparison do not match.
Date Tue, 21 Feb 2012 22:10:51 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213010#comment-13213010
] 

Phabricator commented on HIVE-2813:
-----------------------------------

cwsteinbach has requested changes to the revision "HIVE-2813 [jira] Throw a Hive error if
we're in strict mode and a the types of a partition comparison do not match.".

INLINE COMMENTS
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:342 Please add this to conf/hive-default.xml.template
along with a description of what it does, and the allowed values.
  ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java:59 spelling: "nonstric"
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java:215 spelling
  ql/src/test/queries/clientnegative/select_partcol_diff_types.q:1 Please add a positive testcase
that explicitly sets hive.partition.comparison.mode=nonstrict so that we can test the WARNING
message.

REVISION DETAIL
  https://reviews.facebook.net/D1803

BRANCH
  trunk

                
> Throw a Hive error if we're in strict mode and a the types of a partition comparison
do not match.
> --------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2813
>                 URL: https://issues.apache.org/jira/browse/HIVE-2813
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.8.1, 0.9.0
>            Reporter: Dmitry Soshnikov
>            Priority: Minor
>              Labels: newbie, patch
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2813.D1803.2.patch, HIVE-2813.D1803.3.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Oftentimes people try to write queries like
> SELECT *
> FROM table
> WHERE ds = 2011-08-03
> This won't work because quotes are missing, and it'll actually try to filter on ds =
"2000".
> People run into this pretty regularly; a simple check on whether the types match exactly
in partition predicates would make this a lot less likely to happen.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message