Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F09EB8E7 for ; Wed, 18 Jan 2012 03:14:28 +0000 (UTC) Received: (qmail 19621 invoked by uid 500); 18 Jan 2012 03:14:28 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 18843 invoked by uid 500); 18 Jan 2012 03:14:14 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 18796 invoked by uid 500); 18 Jan 2012 03:14:11 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 18779 invoked by uid 99); 18 Jan 2012 03:14:10 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2012 03:14:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2012 03:14:07 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 9C19F152F53 for ; Wed, 18 Jan 2012 03:13:46 +0000 (UTC) Date: Wed, 18 Jan 2012 03:13:46 +0000 (UTC) From: "Phabricator (Updated) (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <247738150.51490.1326856426640.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <752251727.46715.1326762108095.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HIVE-2720) Merge MetaStoreListener and HiveMetaHook interfaces MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HIVE-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HIVE-2720: ------------------------------ Attachment: HIVE-2720.D1299.1.patch enis requested code review of "HIVE-2720 [jira] Merge MetaStoreListener and HiveMetaHook interfaces". Reviewers: JIRA HIVE-2720. Merge MetaStoreListener and HiveMetaHook interfaces. First version of the patch MetaStoreListener and HiveMetaHook both serve as a notification mechanism for metastore-related events. The former is used by hcat and the latter is by the hbase-storage handler, and invoked by the client. I propose to merge these interfaces, and extend the MetaStoreListener, to add most of the on- and pre- methods at the Thrift interface. This way, extending metastore will be easier, and validation, storage-driver notification, and enforcement can be delegated to individual listeners. Besides, more functionality can be plugged-in by Hcat at this level. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1299 AFFECTED FILES hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaHookLoader.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListenerLoader.java metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateDatabaseEvent.java metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateTableEvent.java metastore/src/java/org/apache/hadoop/hive/metastore/events/DropDatabaseEvent.java metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java metastore/src/java/org/apache/hadoop/hive/metastore/events/LoadPartitionDoneEvent.java ql/src/java/org/apache/hadoop/hive/ql/metadata/DefaultStorageHandler.java ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2703/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. > Merge MetaStoreListener and HiveMetaHook interfaces > --------------------------------------------------- > > Key: HIVE-2720 > URL: https://issues.apache.org/jira/browse/HIVE-2720 > Project: Hive > Issue Type: Sub-task > Components: JDBC, Metastore, ODBC, Security > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Attachments: HIVE-2720.D1299.1.patch > > > MetaStoreListener and HiveMetaHook both serve as a notification mechanism for metastore-related events. The former is used by hcat and the latter is by the hbase-storage handler, and invoked by the client. > I propose to merge these interfaces, and extend the MetaStoreListener, to add most of the on- and pre- methods at the Thrift interface. This way, extending metastore will be easier, and validation, storage-driver notification, and enforcement can be delegated to individual listeners. Besides, more functionality can be plugged-in by Hcat at this level. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira