hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-2705) SemanticAnalyzer twice swallows an exception it shouldn't
Date Tue, 10 Jan 2012 21:11:39 GMT

     [ https://issues.apache.org/jira/browse/HIVE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jakob Homan updated HIVE-2705:
------------------------------

    Attachment: HIVE-2705.patch

Simple patch fixes the two instances of this I found in SemanticAnalyzer.  I'm not wild about
taking the message and making it the new exception's message, rather than just completely
wrapping the original, but this is consistent with other uses in the file.  This is a simple
change, so I've not included tests, but did verify the new code while debugging a separate
issue.
                
> SemanticAnalyzer twice swallows an exception it shouldn't
> ---------------------------------------------------------
>
>                 Key: HIVE-2705
>                 URL: https://issues.apache.org/jira/browse/HIVE-2705
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.7.1
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.8.1
>
>         Attachments: HIVE-2705.patch
>
>
> Twice SemanticAnalyzer catches an exception and drops it, just passing on the original
message's in a new SemanticException. This means that those that see the message in the output
cannot tell what generated the original exception.  These original exceptions should be wrapped,
as they are in other parts of the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message