hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2203) Extend concat_ws() UDF to support arrays of strings
Date Mon, 09 Jan 2012 09:22:40 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182425#comment-13182425
] 

Phabricator commented on HIVE-2203:
-----------------------------------

cwsteinbach has requested changes to the revision "HIVE-2203 [jira] Extend concat_ws() UDF
to support arrays of strings".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:64 Calling getTypeName
and comparing strings is hacky. Instead lets cast the oi to a ListObjectInspector and call
getListElementObjectInspector().
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:114 Indentation.

REVISION DETAIL
  https://reviews.facebook.net/D1119

                
> Extend concat_ws() UDF to support arrays of strings
> ---------------------------------------------------
>
>                 Key: HIVE-2203
>                 URL: https://issues.apache.org/jira/browse/HIVE-2203
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>            Reporter: Carl Steinbach
>            Assignee: Zhenxiao Luo
>            Priority: Minor
>         Attachments: HIVE-2203.D1065.1.patch, HIVE-2203.D1071.1.patch, HIVE-2203.D1113.1.patch,
HIVE-2203.D1119.1.patch
>
>
> concat_ws() should support the following type of input parameters:
> concat_ws(string separator, array<string>)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message