hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-123) refactor DDL code (both DDLWork and DDLTask)
Date Sun, 29 Jan 2012 07:18:10 GMT

    [ https://issues.apache.org/jira/browse/HIVE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195701#comment-13195701
] 

Phabricator commented on HIVE-123:
----------------------------------

hobbymanyp has commented on the revision "HIVE-123 [jira] refactor DDL code (both DDLWork
and DDLTask)".

  I am following up the instruction on https://cwiki.apache.org/Hive/phabricatorcodereview.html
 .  If this is not correct, where is the right one? (or instruction?)


REVISION DETAIL
  https://reviews.facebook.net/D1485

                
> refactor DDL code (both DDLWork and DDLTask)
> --------------------------------------------
>
>                 Key: HIVE-123
>                 URL: https://issues.apache.org/jira/browse/HIVE-123
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Ashutosh Chauhan
>              Labels: cleanup, refactoring
>         Attachments: HIVE-123.D1485.1.patch, hive-123.patch
>
>
> It might be good to break DDLTask into separate tasks. The abstract class DDLWork can
have various subclasses:
> showTablesWork, DescribeTableWork etc. and a separate task for each of them. This will
make them completely independent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message