Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Wed, 21 Dec 2011 17:21:30 +0000 (UTC)
From: "Namit Jain (Created) (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: 
 <36797017.36090.1324488090628.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Created] (HIVE-2668) Minor cleanup to HIVE-2642
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Minor cleanup to HIVE-2642
--------------------------

                 Key: HIVE-2668
                 URL: https://issues.apache.org/jira/browse/HIVE-2668
             Project: Hive
          Issue Type: Improvement
            Reporter: Namit Jain
            Assignee: He Yongqiang


INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRProcContext.java:105 can you add some comments here ?

This is not really the top operators - this contains the list of intermediate tables also. This code is difficult to debug later on, so more comments would be helpful


Look at union22.q.out.

map-join followed by union, an extra stage is introduced.
We dont have to optimize this - just wanted to make sure it is intentional.


1 general comment about the new test union26.q -

Reduce the test output, I mean, you dont need to load all 500 rows for this test.
It makes the test output really difficult to review.


ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRUnion1.java:245 remove this comment

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira