Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CFEAD9CD2 for ; Fri, 16 Dec 2011 04:23:08 +0000 (UTC) Received: (qmail 65948 invoked by uid 500); 16 Dec 2011 04:23:07 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 65918 invoked by uid 500); 16 Dec 2011 04:23:06 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 65898 invoked by uid 99); 16 Dec 2011 04:23:04 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Dec 2011 04:23:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D55F51C2FE7; Fri, 16 Dec 2011 04:23:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4429097721256187334==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-2005 Implement BETWEEN operator From: "Navis Ryu" To: "John Sichi" , "Carl Steinbach" Date: Fri, 16 Dec 2011 04:23:03 -0000 Message-ID: <20111216042303.10101.66290@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3008/ Cc: "Navis Ryu" ,"hive" In-Reply-To: <20111216020908.10101.73702@reviews.apache.org> References: <20111216020908.10101.73702@reviews.apache.org> --===============4429097721256187334== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ ----------------------------------------------------------- (Updated 2011-12-16 04:23:03.804398) Review request for hive, John Sichi and Carl Steinbach. Summary ------- Revised version using 'between' UDF This addresses bug HIVE-2005. https://issues.apache.org/jira/browse/HIVE-2005 Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4 = ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7 = ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java = PRE-CREATION = ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION = ql/src/test/results/clientpositive/show_functions.q.out e63516d = ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION = Diff: https://reviews.apache.org/r/3008/diff Testing ------- added new test : udf_between.q Thanks, Navis --===============4429097721256187334==--