Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 450497BF4 for ; Thu, 15 Dec 2011 19:24:04 +0000 (UTC) Received: (qmail 42373 invoked by uid 500); 15 Dec 2011 19:24:04 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 42314 invoked by uid 500); 15 Dec 2011 19:24:03 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 42296 invoked by uid 99); 15 Dec 2011 19:24:02 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Dec 2011 19:24:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 338C21C2AF7; Thu, 15 Dec 2011 19:24:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5172523067403707317==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-2544: Nullpointer on registering udfs. From: "Ashutosh Chauhan" To: "Bennie Schut" , "Ashutosh Chauhan" , "hive" Date: Thu, 15 Dec 2011 19:24:02 -0000 Message-ID: <20111215192402.26606.92288@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/2702/ In-Reply-To: <20111103134748.16339.69779@reviews.apache.org> References: <20111103134748.16339.69779@reviews.apache.org> --===============5172523067403707317== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2702/#review3927 ----------------------------------------------------------- trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java Is it possible to write a test case, which spins 10s of threads doing o= perations. Thats not fool-proof but will result in some coverage. Unless yo= u have a better idea for writing test case for this. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java Its LinkedHashMap right now, changing it to Concurrent will violate the= contract of LinkedHashMap which you can iterate in same order as your inse= rts. Not sure if violating that is alright here. - Ashutosh On 2011-11-03 13:47:48, Bennie Schut wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2702/ > ----------------------------------------------------------- > = > (Updated 2011-11-03 13:47:48) > = > = > Review request for hive. > = > = > Summary > ------- > = > HIVE-2544: Nullpointer on registering udfs. > = > = > This addresses bug HIVE-2544. > https://issues.apache.org/jira/browse/HIVE-2544 > = > = > Diffs > ----- > = > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java = 1196618 = > = > Diff: https://reviews.apache.org/r/2702/diff > = > = > Testing > ------- > = > = > Thanks, > = > Bennie > = > --===============5172523067403707317==--