Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF09A76BE for ; Wed, 7 Dec 2011 07:01:32 +0000 (UTC) Received: (qmail 35280 invoked by uid 500); 7 Dec 2011 07:01:32 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 35246 invoked by uid 500); 7 Dec 2011 07:01:31 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 35229 invoked by uid 99); 7 Dec 2011 07:01:31 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2011 07:01:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 98A601C2C1A; Wed, 7 Dec 2011 07:01:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6291141073902332159==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-2332 If all of the parameters of distinct functions are exists in group by columns, query fails in runtime From: "Navis Ryu" To: "John Sichi" , "Carl Steinbach" Date: Wed, 07 Dec 2011 07:01:30 -0000 Message-ID: <20111207070130.25014.66564@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1314/ Cc: "Navis Ryu" ,"hive" In-Reply-To: <20111115085607.8166.59164@reviews.apache.org> References: <20111115085607.8166.59164@reviews.apache.org> --===============6291141073902332159== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1314/ ----------------------------------------------------------- (Updated 2011-12-07 07:01:30.547976) Review request for hive, John Sichi and Carl Steinbach. Changes ------- Adding null keys induced confusions especially for optimizers. This patch j= ust modifies key-order minimizing side effects. Summary ------- If all of the distinct params are in group by keys, union column reserved f= or distinct params would not be added, which making problems initializing R= S operator. This patch is just a simple bypass adding dummy expression for the union co= lumn. Someone would know better way to resolve the problem. This addresses bug HIVE-2332. https://issues.apache.org/jira/browse/HIVE-2332 Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 732a5a= a = ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java c6ae55d = ql/src/test/queries/clientpositive/groupby_distinct_samekey.q PRE-CREATIO= N = ql/src/test/results/clientpositive/groupby_distinct_samekey.q.out PRE-CRE= ATION = Diff: https://reviews.apache.org/r/1314/diff Testing ------- added clientpositive/groupby_distinct_samekey.q Thanks, Navis --===============6291141073902332159==--