hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request: Pass user identity in metastore connection in unsecure mode
Date Mon, 19 Dec 2011 22:57:49 GMT
I am not adding any infrastructure in HCatalog. Its already there. I am
just adding tests in it. Adding such an infrastructure is a major
undertaking, which if Hive project agrees could be done. But, thats beyond
the scope of HIVE-2616. We can do that in followup work.

Ashutosh

On Mon, Dec 19, 2011 at 14:54, Carl Steinbach <carl@cloudera.com> wrote:

>
>
> > On 2011-12-19 22:35:15, Ashutosh Chauhan wrote:
> > > About testing, see my earlier comment. To do any real tests for this,
> one needs to do 'sudo' and then run tests. I have not found an easy way to
> do that in Hive. HCatalog has test infrastructure which makes this kind of
> thing possible, where I am adding these tests. See, HCATALOG-181 Also, I
> have manually verified all four combinations of new/old client and new/old
> server and results were of my satisfaction.
>
> Wouldn't it make more sense to add this test infrastructure directly to
> Hive where the feature is implemented? Also, manually testing this feature
> today does nothing to prevent someone from breaking it tomorrow. That's why
> we need automated test coverage for this patch.
>
>
> - Carl
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2975/#review3985
> -----------------------------------------------------------
>
>
> On 2011-12-17 02:42:36, Ashutosh Chauhan wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/2975/
> > -----------------------------------------------------------
> >
> > (Updated 2011-12-17 02:42:36)
> >
> >
> > Review request for hive.
> >
> >
> > Summary
> > -------
> >
> > Pass user identity in metastore connection in unsecure mode
> >
> >
> > This addresses bug HIVE-2616.
> >     https://issues.apache.org/jira/browse/HIVE-2616
> >
> >
> > Diffs
> > -----
> >
> >   trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1215380
> >   trunk/conf/hive-default.xml.template 1215380
> >   trunk/metastore/if/hive_metastore.thrift 1215380
> >   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1215380
> >   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1215380
> >
> trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp
> 1215380
> >
> trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
> 1215380
> >
> trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
> 1215380
> >
> trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
> 1215380
> >
> trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
> 1215380
> >   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1215380
> >
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> 1215380
> >
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> 1215380
> >
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java
> PRE-CREATION
> >   trunk/shims/ivy.xml 1215380
> >
> trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
> 1215380
> >
> trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
> 1215380
> >
> trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
> 1215380
> >
> trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/client/TUGIAssumingTransport.java
> PRE-CREATION
> >
> trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java
> 1215380
> >
> trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/TFilterTransport.java
> PRE-CREATION
> >
> trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/TUGIContainingTransport.java
> PRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/2975/diff
> >
> >
> > Testing
> > -------
> >
> > All the tests in metastore dir passes. Manually tested that file on hdfs
> is owned by user running the client and not by user running metastore
> server.
> >
> >
> > Thanks,
> >
> > Ashutosh
> >
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message