hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-2503: create per-session HiveConf instance
Date Tue, 20 Dec 2011 02:08:07 GMT


> On 2011-12-19 22:35:46, Carl Steinbach wrote:
> > > If we use 'standAloneServer' in TestHiveServer.class, it is very simple to
make the test case. But it seemed to be 'false' which makes it more complex.
> > 
> > Can you supply a version of this test so I can take a look. I'm curious to know
why it doesn't work. Thanks.
> 
> Navis Ryu wrote:
>     I think it cannot be tested by making two instance of client, cause "SessionState"
is a ThreadLocal thing.. Is it right?

Yup, that makes sense.


- Carl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2820/#review3986
-----------------------------------------------------------


On 2011-12-16 05:44:15, Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2820/
> -----------------------------------------------------------
> 
> (Updated 2011-12-16 05:44:15)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Summary
> -------
> 
> We uses multiple HiveClient connected to single HiveServer. After configuring connections,
we've found the environment variables are different from expected. 
> Current hive server uses single instance of HiveConf and this seemed to make the problem.
> 
> 
> This addresses bug HIVE-2503.
>     https://issues.apache.org/jira/browse/HIVE-2503
> 
> 
> Diffs
> -----
> 
>   service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 
>   service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/2820/diff
> 
> 
> Testing
> -------
> 
> If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test
case. But it seemed to be 'false' which makes it more complex.
> 
> 
> Thanks,
> 
> Navis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message