hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request: HIVE-2503: create per-session HiveConf instance
Date Fri, 16 Dec 2011 05:44:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2820/
-----------------------------------------------------------

(Updated 2011-12-16 05:44:15.242903)


Review request for hive and Carl Steinbach.


Changes
-------

I know the test code is very awkward, but that was what I've expected from HiveServer.


Summary
-------

We uses multiple HiveClient connected to single HiveServer. After configuring connections,
we've found the environment variables are different from expected. 
Current hive server uses single instance of HiveConf and this seemed to make the problem.


This addresses bug HIVE-2503.
    https://issues.apache.org/jira/browse/HIVE-2503


Diffs (updated)
-----

  service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 
  service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION


Diff: https://reviews.apache.org/r/2820/diff


Testing
-------

If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case.
But it seemed to be 'false' which makes it more complex.


Thanks,

Navis


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message