hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request: HIVE-2005 Implement BETWEEN operator
Date Fri, 16 Dec 2011 03:58:13 GMT


> On 2011-12-16 03:26:25, Carl Steinbach wrote:
> > ql/src/test/queries/clientpositive/udf_between.q, line 1
> > <https://reviews.apache.org/r/3008/diff/5/?file=64857#file64857line1>
> >
> >     I'm not sure why you changed this testcase. The original version was better.
> >     
> >     * The first two lines should be:
> >     DESCRIBE FUNCTION between
> >     DESCRIBE FUNCTION EXTENDED between;
> >     
> >     * Please call EXPLAIN on each query before running it.
> >     
> >     * Is there any reason in particular why you create the T1 table instead of reusing
the 'src' table that gets created automatically for all CliDriver tests? Loading data will
definitely make the test run more slowly.

Cause renaming 'btw' to 'between' made impossible to compile queries like 'SELECT between(false,
'b', 'a', 'c') FROM src LIMIT 1;'. Could you give me some better test queries?

I'll add DESCRIBE part and EXPLAIN part, shortly. 


- Navis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3943
-----------------------------------------------------------


On 2011-12-16 02:09:08, Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3008/
> -----------------------------------------------------------
> 
> (Updated 2011-12-16 02:09:08)
> 
> 
> Review request for hive, John Sichi and Carl Steinbach.
> 
> 
> Summary
> -------
> 
> Revised version using 'between' UDF
> 
> 
> This addresses bug HIVE-2005.
>     https://issues.apache.org/jira/browse/HIVE-2005
> 
> 
> Diffs
> -----
> 
>   ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out e63516d 
>   ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/3008/diff
> 
> 
> Testing
> -------
> 
> added new test : udf_between.q
> 
> 
> Thanks,
> 
> Navis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message