hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request: HIVE-2544: Nullpointer on registering udfs.
Date Thu, 15 Dec 2011 19:24:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2702/#review3927
-----------------------------------------------------------



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/2702/#comment8870>

    Is it possible to write a test case, which spins 10s of threads doing operations. Thats
not fool-proof but will result in some coverage. Unless you have a better idea for writing
test case for this.



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/2702/#comment8869>

    Its LinkedHashMap right now, changing it to Concurrent will violate the contract of LinkedHashMap
which you can iterate in same order as your inserts.  Not sure if violating that is alright
here.


- Ashutosh


On 2011-11-03 13:47:48, Bennie Schut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2702/
> -----------------------------------------------------------
> 
> (Updated 2011-11-03 13:47:48)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> HIVE-2544: Nullpointer on registering udfs.
> 
> 
> This addresses bug HIVE-2544.
>     https://issues.apache.org/jira/browse/HIVE-2544
> 
> 
> Diffs
> -----
> 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1196618 
> 
> Diff: https://reviews.apache.org/r/2702/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bennie
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message