hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-2005 Implement BETWEEN operator
Date Thu, 15 Dec 2011 08:06:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3923
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
<https://reviews.apache.org/r/3008/#comment8860>

    I was able to get 'between' to work without 'btw' by adding KW_BETWEEN to the list of
sysFuncNames below. Please see if you can get this to work too, and if so then remove any
mention of 'btw' from the patch.



ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
<https://reviews.apache.org/r/3008/#comment8859>

    Add KW_BETWEEN to the list of sysFuncNames here.


- Carl


On 2011-12-08 04:21:44, Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3008/
> -----------------------------------------------------------
> 
> (Updated 2011-12-08 04:21:44)
> 
> 
> Review request for hive, John Sichi and Carl Steinbach.
> 
> 
> Summary
> -------
> 
> Revised version using 'between' UDF
> 
> 
> This addresses bug HIVE-2005.
>     https://issues.apache.org/jira/browse/HIVE-2005
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION

>   ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out e63516d 
>   ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/3008/diff
> 
> 
> Testing
> -------
> 
> added new test : udf_between.q
> 
> 
> Thanks,
> 
> Navis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message