hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request: HIVE-2329 RS dedup optimization shoud be avoided in some cases
Date Wed, 07 Dec 2011 08:15:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1313/
-----------------------------------------------------------

(Updated 2011-12-07 08:15:06.858543)


Review request for hive, John Sichi and Carl Steinbach.


Changes
-------

rebased to trunk


Summary
-------

If map aggregation is set to false, DISTRIBUTED BY followed by GROUP BY with same key fails
in runtime. ReduceSinkDeDuplication optimization should be avoid if child of child RS is GBY.



This addresses bug HIVE-2329.
    https://issues.apache.org/jira/browse/HIVE-2329


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java e91b4d5 
  ql/src/test/queries/clientpositive/reduce_deduplicate_exclude_gby.q PRE-CREATION 
  ql/src/test/results/clientpositive/reduce_deduplicate_exclude_gby.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1313/diff


Testing (updated)
-------

test added : reduce_deduplicate_exclude_gby.q


Thanks,

Navis


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message