hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sichi" <jsi...@fb.com>
Subject Re: Review Request: HIVE-2362. HiveConf properties not appearing in the output of 'set' or 'set -v'
Date Mon, 05 Dec 2011 23:39:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2960/#review3648
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/2960/#comment8142>

    Carl, there is an addResource overload which takes an InputStream.  Can't we use that
plus ByteArrayOutputStream to avoid having to create a temporary file?


- John


On 2011-12-05 21:15:13, Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2960/
> -----------------------------------------------------------
> 
> (Updated 2011-12-05 21:15:13)
> 
> 
> Review request for hive and John Sichi.
> 
> 
> Summary
> -------
> 
> Fix for HIVE-2362.
> 
> 
> This addresses bug HIVE-2362.
>     https://issues.apache.org/jira/browse/HIVE-2362
> 
> 
> Diffs
> -----
> 
>   eclipse-templates/.classpath b020907 
>   common/src/test/resources/hive-site.xml PRE-CREATION 
>   conf/hive-default.xml 53eca0e 
>   common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java PRE-CREATION 
>   build-common.xml 1d162de 
>   common/build.xml 432eba5 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d9b6fd5 
> 
> Diff: https://reviews.apache.org/r/2960/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carl
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message