hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
Date Fri, 16 Dec 2011 05:45:31 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170793#comment-13170793
] 

jiraposter@reviews.apache.org commented on HIVE-2503:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2820/
-----------------------------------------------------------

(Updated 2011-12-16 05:44:15.242903)


Review request for hive and Carl Steinbach.


Changes
-------

I know the test code is very awkward, but that was what I've expected from HiveServer.


Summary
-------

We uses multiple HiveClient connected to single HiveServer. After configuring connections,
we've found the environment variables are different from expected. 
Current hive server uses single instance of HiveConf and this seemed to make the problem.


This addresses bug HIVE-2503.
    https://issues.apache.org/jira/browse/HIVE-2503


Diffs (updated)
-----

  service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 
  service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION


Diff: https://reviews.apache.org/r/2820/diff


Testing
-------

If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case.
But it seemed to be 'false' which makes it more complex.


Thanks,

Navis


                
> HiveServer should provide per session configuration
> ---------------------------------------------------
>
>                 Key: HIVE-2503
>                 URL: https://issues.apache.org/jira/browse/HIVE-2503
>             Project: Hive
>          Issue Type: Bug
>          Components: CLI, Server Infrastructure
>    Affects Versions: 0.9.0
>            Reporter: Navis
>            Assignee: Navis
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2503.1.patch.txt
>
>
> Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler,
making impossible to use per sesssion configuration. Just wrapping 'conf' -> 'new HiveConf(conf)'
seemed to solve this problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message