hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marek Sapota (Updated) (JIRA)" <>
Subject [jira] [Updated] (HIVE-1040) use sed rather than diff for masking out noise in diff-based tests
Date Mon, 05 Dec 2011 03:03:43 GMT


Marek Sapota updated HIVE-1040:

    Attachment: HIVE-1040.1.patch

Phabricator doesn't like the patch as it's too big and `arc diff` produces an error=/
> use sed rather than diff for masking out noise in diff-based tests
> ------------------------------------------------------------------
>                 Key: HIVE-1040
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>          Components: Testing Infrastructure
>    Affects Versions: 0.4.1
>            Reporter: John Sichi
>            Assignee: Marek Sapota
>            Priority: Minor
>         Attachments: HIVE-1040.1.patch
> The current diff -I approach has two problems:  (1) it does not allow resolution finer
than line-level, so it's impossible to mask out pattern occurrences within a line, and (2)
it produces unmasked files, so if you run diff on the command line to compare the result .q.out
with the checked-in file, you see the noise.
> My suggestion is to first run sed to replace noise patterns with an unlikely-to-occur
string like ZYZZYZVA, and then diff the pre-masked files without using any -I.
> This would require a one-time hit to update all existing .q.out files so that they would
contain the pre-masked results.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message