hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2586) Float comparison doesn't work
Date Thu, 08 Dec 2011 09:33:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165115#comment-13165115
] 

jiraposter@reviews.apache.org commented on HIVE-2586:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3073/
-----------------------------------------------------------

Review request for hive, John Sichi and Carl Steinbach.


Summary
-------

Is there any reason should not to implement comparing float/double?


This addresses bug HIVE-2586.
    https://issues.apache.org/jira/browse/HIVE-2586


Diffs
-----

  data/files/floatdouble.txt PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 59e55ae 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java 3fb3879 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqual.java dc4670e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrGreaterThan.java f44f353

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrLessThan.java 7d74e82

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPGreaterThan.java 47fceb1 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPLessThan.java 12369a8 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNotEqual.java 22b3bef 
  ql/src/test/queries/clientpositive/compare_float_double.q PRE-CREATION 
  ql/src/test/results/clientpositive/compare_float_double.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/3073/diff


Testing
-------

added test : compare_float_double.q


Thanks,

Navis


                
> Float comparison doesn't work
> -----------------------------
>
>                 Key: HIVE-2586
>                 URL: https://issues.apache.org/jira/browse/HIVE-2586
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Priority: Minor
>
> Create table with float column, insert to it e.g. 1410.1, and then do select * from <that
table> where <that column> = 1410.1 . Nothing will be found. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message