Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Wed, 9 Nov 2011 21:39:53 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: 
 <452681492.15654.1320874793043.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1254445347.12829.1320802192365.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HIVE-2562) HIVE-2247 Changed the Thrift API
 causing compatibility issues.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147314#comment-13147314 ] 

jiraposter@reviews.apache.org commented on HIVE-2562:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/
-----------------------------------------------------------

(Updated 2011-11-09 21:38:50.463372)


Review request for hive, Siying Dong and Kevin Wilfong.


Changes
-------

Address Ning's comment


Summary
-------

keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch


This addresses bug HIVE-2562.
    https://issues.apache.org/jira/browse/HIVE-2562


Diffs (updated)
-----

  trunk/metastore/if/hive_metastore.thrift 1199943 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 
  trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 

Diff: https://reviews.apache.org/r/2783/diff


Testing
-------


Thanks,

Weiyan


> HIVE-2247 Changed the Thrift API causing compatibility issues.
> --------------------------------------------------------------
>
>                 Key: HIVE-2562
>                 URL: https://issues.apache.org/jira/browse/HIVE-2562
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Kevin Wilfong
>            Assignee: Weiyan Wang
>         Attachments: HIVE-2562-1.patch, HIVE-2562.patch
>
>
> HIVE-2247 Added a parameter to alter_partition in the Metastore Thrift API which has been causing compatibility issues with some scripts.  We would like to change this to have two methods, one called alter_partition which takes the old parameters, and one called something else (I'll leave the naming up to you) which has the new parameters.  The implementation of the old method should just call the new method with null for the new parameter.
> This will fix the compatibility issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira